Skip to content

Fix testing app for oracle#23

Merged
PVince81 merged 1 commit into
masterfrom
fix_oracle_testing
Sep 10, 2018
Merged

Fix testing app for oracle#23
PVince81 merged 1 commit into
masterfrom
fix_oracle_testing

Conversation

@patrickjahns

@patrickjahns patrickjahns commented Sep 7, 2018

Copy link
Copy Markdown
Contributor

Description

Fix running acceptance+ui tests on drone

Taken from owncloud/core#31145

Checklist:

Comment thread lib/Application.php
$userManager->clearBackends();
$userManager->registerBackend($c->query(AlternativeHomeUserBackend::class));

$userManager->listen('\OC\User', 'postCreateUser', function ($user, $password) use ($c) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is only for fixing Oracle, I don't see why the code has been moved outside of the "postCreateUser" hook instead of just changing the literal

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was from TM patch

What's the intention of this postCreateUser here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added this back then to delay updating the accounts table to after the admin user got created, because in some cases it would happen too early. Not sure if this time we got lucky or other core changes would remove the need for this.

If this doesn't break acceptance tests on core then I'm fine keeping it this way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://drone.owncloud.com/owncloud/core/10273 - acceptance tests are all green

@PVince81 PVince81 merged commit 06ffece into master Sep 10, 2018
@PVince81 PVince81 deleted the fix_oracle_testing branch September 10, 2018 20:35
@PVince81

Copy link
Copy Markdown
Contributor

I've updated "latest"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants