Skip to content

fake set displayname support#151

Closed
butonic wants to merge 1 commit into
masterfrom
sync-displayname-on-login
Closed

fake set displayname support#151
butonic wants to merge 1 commit into
masterfrom
sync-displayname-on-login

Conversation

@butonic

@butonic butonic commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

core will only uppdate the account if the backend supports setting it. this is a workaround. needs fixing in core. but core should handle the sync update anyway.

@butonic

butonic commented Nov 22, 2017

Copy link
Copy Markdown
Contributor Author

I guess this needs to also meke it into the release branch

@codecov-io

codecov-io commented Nov 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #151 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
+ Coverage     25.56%   25.57%   +<.01%     
- Complexity     1311     1312       +1     
============================================
  Files            47       47              
  Lines          5022     5025       +3     
============================================
+ Hits           1284     1285       +1     
- Misses         3738     3740       +2
Impacted Files Coverage Δ Complexity Δ
lib/User_Proxy.php 0% <0%> (ø) 42 <1> (+1) ⬆️
lib/User_LDAP.php 44.23% <100%> (+0.54%) 36 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b4197...5c40c5b. Read the comment docs.

@butonic

butonic commented Nov 28, 2017

Copy link
Copy Markdown
Contributor Author

superseded by owncloud/core#29669, but still needs to go in to make it work with 10.0.4

@tomneedham

Copy link
Copy Markdown
Contributor

already in release branch - will be merged back in

@tomneedham tomneedham closed this Dec 20, 2017
@DeepDiver1975 DeepDiver1975 deleted the sync-displayname-on-login branch December 20, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants