Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Feature/streamed file list#2299

Closed
DeepDiver1975 wants to merge 2 commits into
masterfrom
feature/streamed-file-list
Closed

Feature/streamed file list#2299
DeepDiver1975 wants to merge 2 commits into
masterfrom
feature/streamed-file-list

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Oct 21, 2019

Copy link
Copy Markdown
Member

Description

POC implementation of streamed parsing of propfind response

Motivation and Context

Moving the heavy load to a web worker will unblock the UI for larger folders (1000+ elements)
Reading propfind response elements in a stream manner allows faster feedback to the user.

Virtual scrolling is necessary - vuejs(or at least the way we are using it) cannot properly render 1000 elements and update the UI properly.

Plan for production ready code base:

  • move davclient.js to the sdk
  • move xml.js to the sdk
  • name FileList.js to file worker
  • spec proper web worker api - like have an action name in the messsage so that the web worker knows which operation is call
  • implement favorites and public files access

How Has This Been Tested?

  • create a folder
  • upload 1000 files (maybe in the data folder via bash and call file scan ...)
  • load the folder in phoenix
  • the ui shall not block (browser warning)
  • file list is loaded in chunks (not that smooth yet because of missing virtual scrolling - requires Files table virtual scroller #2280 )
  • as long as the list is being loaded a spinner is visible in the footer

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975
DeepDiver1975 force-pushed the feature/streamed-file-list branch from a25bf6a to 2b7415a Compare October 25, 2019 09:01
@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Upload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-092703-762.png
20191025-092737-357.png
20191025-092814-215.png
20191025-092848-825.png
20191025-092923-353.png
20191025-093005-807.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests RenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-093230-194.png
20191025-093303-516.png
20191025-093326-554.png
20191025-093359-216.png
20191025-093422-397.png
20191025-093457-395.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-092540-719.png
20191025-092617-886.png
20191025-092809-566.png
20191025-092842-473.png
20191025-093031-256.png
20191025-093137-914.png
20191025-093220-619.png
20191025-093304-727.png
20191025-093348-493.png
20191025-093431-766.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-092530-401.png
20191025-092606-234.png
20191025-092651-000.png
20191025-092736-847.png
20191025-092811-971.png
20191025-092847-750.png
20191025-092934-689.png
20191025-093009-977.png
20191025-093044-808.png
20191025-093119-548.png
20191025-093252-988.png
20191025-093253-199.png
20191025-093319-109.png
20191025-093319-355.png
20191025-093334-943.png
20191025-093350-604.png
20191025-093436-405.png
20191025-093522-608.png
20191025-093539-652.png
20191025-093557-251.png
20191025-093614-404.png
20191025-093631-880.png
20191025-093649-506.png
20191025-093707-201.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-093207-684.png
20191025-093250-528.png
20191025-093342-643.png
20191025-093433-015.png
20191025-093544-049.png
20191025-093616-963.png
20191025-093936-336.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-092734-915.png
20191025-092814-470.png
20191025-092901-759.png
20191025-092948-973.png
20191025-094816-283.png
20191025-094855-611.png
20191025-094935-155.png
20191025-095015-287.png
20191025-095055-569.png
20191025-095135-975.png
20191025-095215-946.png
20191025-095256-144.png
20191025-095335-673.png
20191025-095415-863.png
20191025-095856-372.png
20191025-095934-084.png
20191025-100021-689.png
20191025-100109-840.png
20191025-100148-379.png
20191025-100229-902.png

@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5979/

20191025-093139-466.png
20191025-093218-676.png
20191025-093305-769.png
20191025-093352-257.png
20191025-095125-887.png
20191025-095214-893.png
20191025-095254-433.png
20191025-095334-891.png
20191025-095414-757.png
20191025-095453-690.png
20191025-095532-534.png
20191025-095612-042.png
20191025-095652-309.png
20191025-095731-354.png
20191025-100206-139.png
20191025-100243-268.png
20191025-100321-066.png
20191025-100400-833.png
20191025-100440-312.png
20191025-100517-657.png

@DeepDiver1975
DeepDiver1975 deleted the feature/streamed-file-list branch March 10, 2020 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants