[tests-only] Do not retry failed acceptance tests in cron nightly

[phil-davis]

Description

PR #5409 tries to report failed scenarios to RocketChat when a scenario fails and has to be rerun. That would be useful in the nightly CI run, because in that case there is no PR to post a comment to on GitHub. But that had difficulty getting a flexible message to be posted (rather than just a pass/fail kind of message)

Rather than keep trying to achieve individual RocketChat notifications for each failed test, this PR simply runs the nightly CI without the --retry 1 parameter. Any test scenario(s) that fails will cause the drone pipeline to fail. When the whole nightly job finishes it reports overall success or failure to RocketChat already. (That is like what all the other nightly jobs do in other repos). When we see a nightly failure in RocketChat it has a link to drone. We can follow that link and easily see which pipelines failed, and which test scenario(s) failed in the pipeline.

We will get failure for any test that fails the first time. And we want to know about those possibly intermittent tests so that we can work to improve them.

How Has This Been Tested?

I ran PR #5978 with the retry logic on and ff to check that both work.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ownclouders]

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20057/14/1
The following scenarios passed on retry:

• webUISharingAcceptSharesToRoot/acceptShares.feature:108