Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Hide share actions for space viewers/editors#7470

Merged
JammingBen merged 3 commits into
masterfrom
fix-space-share-actions
Aug 18, 2022
Merged

Hide share actions for space viewers/editors#7470
JammingBen merged 3 commits into
masterfrom
fix-space-share-actions

Conversation

@JammingBen

Copy link
Copy Markdown
Contributor

Description

We've fixed a bug where viewers and editors of a space could see the actions to edit and remove shares. We've also improved the error handling when something goes wrong while editing/removing shares.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 17, 2022
@JammingBen
JammingBen marked this pull request as ready for review August 17, 2022 12:23
Comment thread packages/web-app-files/src/components/SideBar/Shares/FileShares.vue Outdated
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@JammingBen
JammingBen merged commit 5c5cdda into master Aug 18, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the fix-space-share-actions branch August 18, 2022 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space Viewer should not see the edit options on shares

2 participants