Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

[full-ci] Space root not updated#7546

Merged
kulmann merged 3 commits into
masterfrom
issues/7521
Oct 4, 2022
Merged

[full-ci] Space root not updated#7546
kulmann merged 3 commits into
masterfrom
issues/7521

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear
AlexAndBear marked this pull request as ready for review August 30, 2022 08:50
@ownclouders

ownclouders commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/28757/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28757/tracing/public-link-for-space-alice-2022-9-29-11-41-02.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28757/tracing/public-link-for-space-brian-2022-9-29-11-41-31.zip

@AlexAndBear
AlexAndBear requested a review from dschmidt August 30, 2022 14:13
@AlexAndBear

AlexAndBear commented Aug 30, 2022

Copy link
Copy Markdown
Contributor Author

No changelog item needed

lookacat
lookacat approved these changes Aug 30, 2022
View reviewed changes

@lookacat lookacat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

kulmann
kulmann suggested changes Aug 31, 2022
View reviewed changes

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shares display less/other information in the Details panel of the right sidebar now. Please compare following screenshots, first from master, second from your branch:

master

Screenshot 2022-08-31 at 11 26 12

this branch

Screenshot 2022-08-31 at 11 26 26

@AlexAndBear

AlexAndBear commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

Not so good - postponed

@kulmann
kulmann marked this pull request as draft September 2, 2022 11:42
@JammingBen
JammingBen removed their request for review September 21, 2022 09:33
JammingBen
JammingBen reviewed Sep 21, 2022
View reviewed changes
Comment thread packages/web-app-files/src/components/SideBar/SideBar.vue
}

this.loading = true
// shared resources look different, hence we need to fetch the actual resource here

@JammingBen JammingBen Sep 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wondered why we have highlightedFile AND selectedFile. Turns out, it's needed because share resources look different than "normal" resources. Some information like mdate is missing in a built share. Therefore we need to fetch the actual resource in such cases.

Maybe the OCS share API will be extended by the missing properties in the future. Then we could skip this whole fetching-stuff here.

@JammingBen JammingBen changed the title Space root not updated [full-ci] Space root not updated Sep 21, 2022
@JammingBen
JammingBen marked this pull request as ready for review September 21, 2022 11:58
@JammingBen
JammingBen requested a review from kulmann September 21, 2022 11:58
@JammingBen JammingBen mentioned this pull request Sep 27, 2022
Merged
28 tasks
@owncloud owncloud deleted a comment from update-docs Bot Sep 29, 2022
@sonarqubecloud

sonarqubecloud Bot commented Sep 29, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@kulmann
kulmann merged commit c8f8589 into master Oct 4, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the issues/7521 branch October 4, 2022 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dschmidt dschmidt Awaiting requested review from dschmidt
3 more reviewers
@JammingBen JammingBen JammingBen left review comments
@lookacat lookacat lookacat approved these changes
@kulmann kulmann kulmann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Space quota does not update reactively

5 participants

@AlexAndBear @ownclouders @lookacat @kulmann @JammingBen