Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Add hover effect for left sidebar#7567

Merged
JammingBen merged 2 commits into
masterfrom
left-sidebar-hover
Sep 1, 2022
Merged

Add hover effect for left sidebar#7567
JammingBen merged 2 commits into
masterfrom
left-sidebar-hover

Conversation

@JammingBen

Copy link
Copy Markdown
Contributor

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 1, 2022
Comment thread packages/web-runtime/src/components/SidebarNav/SidebarNav.vue
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen
JammingBen merged commit fb0d810 into master Sep 1, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the left-sidebar-hover branch September 1, 2022 10:14
@diocas

diocas commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

This PR is causing a strange visual effect. When I click in the menu, the background of the entry changes immediately. But then the effect that was there before still happens, so you see 2 blue boxes merging.

In the picture you can see what happens when switching from (the previously selected) "Personal" to "Deleted files"
Screenshot 2022-09-01 at 17 29 56

@kulmann

kulmann commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

This PR is causing a strange visual effect. When I click in the menu, the background of the entry changes immediately. But then the effect that was there before still happens, so you see 2 blue boxes merging.

In the picture you can see what happens when switching from (the previously selected) "Personal" to "Deleted files" Screenshot 2022-09-01 at 17 29 56

True... thank you! Fixed in #7575

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent hover effect (left sidebar)

4 participants