Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

[full-ci] Fix spaces on the 'Shared via link'-page#7651

Merged
kulmann merged 5 commits into
masterfrom
fix-spaces-shared-via-link
Sep 20, 2022
Merged

[full-ci] Fix spaces on the 'Shared via link'-page#7651
kulmann merged 5 commits into
masterfrom
fix-spaces-shared-via-link

Conversation

@JammingBen

Copy link
Copy Markdown
Contributor

Description

Spaces on the "Shared via link"-page are now being displayed correctly. Also, the sidebar for those has been fixed.

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 16, 2022
@ownclouders

ownclouders commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/28408/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L162.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

webUISharingPublicManagement-shareByPublicLink_feature-L49.png

@JammingBen JammingBen changed the title Fix spaces on the 'Shared via link'-page [full-ci] Fix spaces on the 'Shared via link'-page Sep 19, 2022
@JammingBen
JammingBen force-pushed the fix-spaces-shared-via-link branch from d9dab38 to cfe77c8 Compare September 19, 2022 08:03
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

21.6% 21.6% Coverage
0.0% 0.0% Duplication

@JammingBen
JammingBen marked this pull request as ready for review September 19, 2022 11:06
Comment thread packages/web-app-files/src/fileSideBars.ts
Comment thread packages/web-app-files/src/components/FilesList/ResourceTable.vue
Comment thread packages/web-app-files/src/services/folder/loaderSharedViaLink.ts

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann
kulmann merged commit c703afe into master Sep 20, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the fix-spaces-shared-via-link branch September 20, 2022 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

link-share of a project space root has no resource name in file list

3 participants