Skip to content

fix(linter/explicit-module-boundary-types): fix false positives for satisfies-wrapped members#20439

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-16-fix_linter_explicit-module-boundary-types_fix_false_positives_for_satisfies-wrapped_members
Mar 16, 2026
Merged

fix(linter/explicit-module-boundary-types): fix false positives for satisfies-wrapped members#20439
graphite-app[bot] merged 1 commit intomainfrom
c/03-16-fix_linter_explicit-module-boundary-types_fix_false_positives_for_satisfies-wrapped_members

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Mar 16, 2026

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Mar 16, 2026
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 16, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review March 16, 2026 21:11
Copilot AI review requested due to automatic review settings March 16, 2026 21:11
@pullfrog
Copy link
Copy Markdown

pullfrog bot commented Mar 16, 2026

This run croaked 😵

The workflow encountered an error before any progress could be reported. Please check the link below for details.

Pullfrog  | Rerun failed job ➔View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@camc314 camc314 self-assigned this Mar 16, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 16, 2026
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 16, 2026

Merge activity

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes explicit-module-boundary-types false positives when exported members are function expressions wrapped in TS “typing” syntax (notably satisfies, plus as / type assertions), so the rule doesn’t require explicit parameter/return annotations in cases where the wrapper already provides the type.

Changes:

  • Skip visiting wrapped arrow/function expressions inside as, satisfies, and type-assertion expressions to avoid reporting missing argument/return types.
  • Add helper to detect function expressions under parens / non-null wrappers.
  • Extend test coverage with satisfies-wrapped members in object literals and class fields.

You can also share your feedback on Copilot code review. Take the survey.

@graphite-app graphite-app bot force-pushed the c/03-16-fix_linter_explicit-module-boundary-types_fix_false_positives_for_satisfies-wrapped_members branch from bdbe9d4 to 6a307d1 Compare March 16, 2026 21:17
@graphite-app graphite-app bot merged commit 6a307d1 into main Mar 16, 2026
21 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 16, 2026
@graphite-app graphite-app bot deleted the c/03-16-fix_linter_explicit-module-boundary-types_fix_false_positives_for_satisfies-wrapped_members branch March 16, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants