Skip to content

feat(linter): implement unicorn/custom-error-definition rule#20520

Merged
camc314 merged 2 commits intooxc-project:mainfrom
baevm:custom-error-def
Mar 19, 2026
Merged

feat(linter): implement unicorn/custom-error-definition rule#20520
camc314 merged 2 commits intooxc-project:mainfrom
baevm:custom-error-def

Conversation

@baevm
Copy link
Copy Markdown
Contributor

@baevm baevm commented Mar 19, 2026

this PR adds unicorn/custom-error-definition rule, passes all original tests

issue #684

@baevm baevm requested a review from camc314 as a code owner March 19, 2026 08:09
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Mar 19, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 19, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1


Comparing baevm:custom-error-def (2798270) with main (6cd513f)2

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (6528f37) during the generation of this report, so 6cd513f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 self-assigned this Mar 19, 2026
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit f9a63ca into oxc-project:main Mar 19, 2026
21 checks passed
costajohnt pushed a commit to costajohnt/oxc that referenced this pull request Mar 22, 2026
…roject#20520)

part of oxc-project#684

---------

Co-authored-by: Cameron Clark <cameron.clark@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants