Skip to content

Test flake in Safari: disk snapshot error #2673

Description

@david-crespo

Safari tests flaked in #2671 on snapshotting a disk with an error response. It's an annoying one — we try to close the first toast when we don't expect the second to have shown up yet, so it's mad that there are two toast close buttons visible. We could add first() here, but that doesn't feel right. I'm thinking we should change the test to not rely on closing the toast if it doesn't need it to.

console/test/e2e/utils.ts

Lines 139 to 142 in 4646ad4

export async function closeToast(page: Page) {
await page.getByRole('button', { name: 'Dismiss notification' }).click()
await sleep(1000)
}

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions