Make vpc, subnet required for NIC creation#1006
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| label="Subnet" | ||
| vpcNameField="vpcName" | ||
| vpcs={vpcs} | ||
| // required |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| const [, { value }, { setValue }] = useField<ItemValue>({ | ||
| name, | ||
| validate: (v) => (required && !v ? `${name} is required` : undefined), | ||
| }) |
Collaborator
There was a problem hiding this comment.
didn't realize you could just do this. nice!
Contributor
Author
There was a problem hiding this comment.
Yep. In practice the error message isn't showing (it's not actually wired up) but that's fine for now. The behavior of not letting us submit until something is selected is what we're really going for.
david-crespo
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #993
3