Rename every API method!#1037
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Jul 7, 2022
| if (method.endsWith('Post')) { | ||
| let resource = camelCaseToWords(method).slice(-2)[0] | ||
| resource = resource.endsWith('s') ? resource.slice(0, -1) : resource | ||
| if (method.endsWith('Create')) { |
Collaborator
Author
There was a problem hiding this comment.
Can't believe it but an e2e test caught this. This is fragile!
Contributor
There was a problem hiding this comment.
Uhh... hmmm... yeah, I wonder if there's a better way to do this.
david-crespo
commented
Jul 7, 2022
| const queryClient = useApiQueryClient() | ||
|
|
||
| const createSshKey = useApiMutation('sshkeysPost', { | ||
| const createSshKey = useApiMutation('sessionSshkeyCreate', { |
Collaborator
Author
There was a problem hiding this comment.
the session prefix is weird for these operation IMO. will raise the issue on the API side
Contributor
|
Nice. I love how it's also a net negative change, haha. Your trend continues! |
just-be-dev
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console integration of oxidecomputer/omicron#1329
This one was pretty fun!