Fix user name pop-in by fetching /session/me in a loader#1164
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Sep 19, 2022
| apiQueryClient.prefetchQuery('organizationPolicyView', requireOrgParams(params)), | ||
| // used to resolve user names | ||
| apiQueryClient.prefetchQuery('userList'), | ||
| apiQueryClient.prefetchQuery('userList', {}), |
Collaborator
Author
There was a problem hiding this comment.
The {} is now required as a result of removing the ? from the params arg. This ensures the call matches the one it's prefetching for — if they don't match, then the call in the component will not reuse this data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at the diff with whitespace changes hidden!
Wrap all authenticated routes in an element-less
Routewith a loader that prefetches/session/me. That way we don't get the user's name popping in in the header as shown below.The loader moves the loading time to before the page has loaded. This is likely not introducing any additional delay to the pageload because it runs in parallel to any other loaders that are already running at that time.