Skip to content

Try macos-14 runner for playwright tests #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
Feb 8, 2024
Merged

Try macos-14 runner for playwright tests #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7476b92
try macos-14 runner for playwright tests
david-crespo Feb 8, 2024
965ed73
bust npm cache
david-crespo Feb 8, 2024
deba04c
missed a node-version
david-crespo Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions .github/workflows/lintBuildTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ on:
jobs:
install:
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: macos-14
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Cache node_modules
uses: actions/cache@v3
Expand All @@ -26,16 +26,13 @@ jobs:
run: npm install
ci:
timeout-minutes: 5
runs-on: ubuntu-latest
runs-on: macos-14
needs: install
steps:
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
- name: Disable packages.microsoft.com repo
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Get node_modules from cache
uses: actions/cache@v3
Expand All @@ -54,20 +51,17 @@ jobs:
playwright:
name: Playwright (${{ matrix.browser }})
timeout-minutes: 20
runs-on: ubuntu-latest
runs-on: macos-14
needs: install
strategy:
fail-fast: false
matrix:
browser: ['chrome', 'firefox', 'safari']
steps:
# This repo is unstable and unnecessary: https://github.com/microsoft/linux-package-repositories/issues/34
- name: Disable packages.microsoft.com repo
run: sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
- name: Get node_modules from cache
uses: actions/cache@v3
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"xterm-addon-attach": "^0.9.0",
"xterm-addon-fit": "^0.8.0",
"zod": "^3.22.4",
"zustand": "^4.4.7"
"zustand": "^4.5.0"
},
"devDependencies": {
"@ianvs/prettier-plugin-sort-imports": "^4.1.1",
Expand Down