Highlight sidebar nav links when in create form#2060
Closed
charliepark wants to merge 8 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… cells (#2055) get wild with prefetches for *NameFromId cells
* Add Type column to access table * Remove AccessNameCell --------- Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
Contributor
Author
|
Ah, crap. A rebase possibly messed this up. This should have been simplified down to just one or two file changes, total, so it might be easier for me to just do this in a new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2038
This PR updates how the Sidebar evaluates the nav links and how their
todestination compares to the current URL.With this change, a create form for a resource (e.g.
/instances-new,/disks-new, etc.) will now show up highlighted, to conform to the parent resource page.The Instances page and
-newpage:And the Disks page and
-newpage:When the form is contained in a SideModal (see
/disks-new, above), the nav link is dimmed a bit.