Improve image upload cleanup logic, reduce e2e flake#2674
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
image-upload-e2e-fix
branch
from
edaab78 to
73af617
Compare
david-crespo
commented
Feb 4, 2025
| await deleteDiskCleanup.mutateAsync({ path: { disk: disk.current.id } }) | ||
| disk.current = null | ||
| } | ||
| cleaningUp.current = false |
Collaborator
Author
There was a problem hiding this comment.
Because we turned this back to false when cleanup was done, it did not prevent it from running twice in the case where the first attempt finished before the second started. Instead, we now prevent it from running twice by only calling it in one place.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 6, 2025
oxidecomputer/console@288f1c1...517353e * [517353ee](oxidecomputer/console@517353ee) bump vite and vitest (vitest CVE) * [a6319fc8](oxidecomputer/console@a6319fc8) oxidecomputer/console#2671 * [5bd61e67](oxidecomputer/console@5bd61e67) oxidecomputer/console#2674 * [4646ad47](oxidecomputer/console@4646ad47) minor: console.log -> console.info in api-diff * [7723212c](oxidecomputer/console@7723212c) log before and after file paths in api-diff * [7cde843f](oxidecomputer/console@7cde843f) minor: deleted temp dir problem in bump-omicron.ts
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 6, 2025
oxidecomputer/console@288f1c1...517353e * [517353ee](oxidecomputer/console@517353ee) bump vite and vitest (vitest CVE) * [a6319fc8](oxidecomputer/console@a6319fc8) oxidecomputer/console#2671 * [5bd61e67](oxidecomputer/console@5bd61e67) oxidecomputer/console#2674 * [4646ad47](oxidecomputer/console@4646ad47) minor: console.log -> console.info in api-diff * [7723212c](oxidecomputer/console@7723212c) log before and after file paths in api-diff * [7cde843f](oxidecomputer/console@7cde843f) minor: deleted temp dir problem in bump-omicron.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix some flakes that came up in #2671 (and periodically for a very long time). I think we were calling cleanup twice more often than I thought.