Fix target for checkbox on instance create form#2808
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Were there other cases @benjaminleonard? It does seem like this is the only one where we used |
david-crespo
approved these changes
May 13, 2025
Contributor
|
Not that I know of, I shall stay vigilant. |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 4, 2025
oxidecomputer/console@46e244f...e891f96 * [e891f968](oxidecomputer/console@e891f968) oxidecomputer/console#2833 * [f2584554](oxidecomputer/console@f2584554) oxidecomputer/console#2832 * [a186ae6f](oxidecomputer/console@a186ae6f) oxidecomputer/console#2825 * [a480ca7f](oxidecomputer/console@a480ca7f) tools: api-diff: switch from difftastic to delta * [ad05de96](oxidecomputer/console@ad05de96) tools: api-diff comment fix * [77d5849d](oxidecomputer/console@77d5849d) tools: fix api-diff to get more precise PR base commit * [f8c05f20](oxidecomputer/console@f8c05f20) oxidecomputer/console#2808 * [50a84bc1](oxidecomputer/console@50a84bc1) bump omicron to latest main for webhook secret timestamp
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 4, 2025
oxidecomputer/console@46e244f...e891f96 * [e891f968](oxidecomputer/console@e891f968) oxidecomputer/console#2833 * [f2584554](oxidecomputer/console@f2584554) oxidecomputer/console#2832 * [a186ae6f](oxidecomputer/console@a186ae6f) oxidecomputer/console#2825 * [a480ca7f](oxidecomputer/console@a480ca7f) tools: api-diff: switch from difftastic to delta * [ad05de96](oxidecomputer/console@ad05de96) tools: api-diff comment fix * [77d5849d](oxidecomputer/console@77d5849d) tools: fix api-diff to get more precise PR base commit * [f8c05f20](oxidecomputer/console@f8c05f20) oxidecomputer/console#2808 * [50a84bc1](oxidecomputer/console@50a84bc1) bump omicron to latest main for webhook secret timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the instance-create table, there's a checkbox that has a gap between the checkbox and the label, mostly because we were re-creating something that already works. This update uses the default checkbox / label approach, making it work like other places in the app.
It is possible I have missed something, so will poke around a bit more to see if there are more broken checkbox/labels.
Fixes #2807