Add errors-allowed version of apiq and use it everywhere#2879
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because there are only a few uses of
useApiQueryErrorsAllowed, it's trivial to convert them all to the new preferred format that lets use vanillauseQuery.Note this leaves in place
apiQueryClient.prefetchQueryErrorsAllowed, which is only used in one spot, but I don't feel like figuring out how to reconcile the slight difference in logic right now.console/app/api/hooks.ts
Lines 320 to 335 in 777a959