add integration tests#290
Conversation
|
Note - if we don't squash and merge, maybe the git history won't be wrecked by this PR? |
|
opened issue #291 |
|
Yeah, see if not squashing will preserve, that's what we want. |
leftwo
left a comment
There was a problem hiding this comment.
Can we verify that if we don't squash it will keep history?
I can try locally. |
|
If I do what I believe is the "rebase and merge" strategy: I believe that preserves history: |
|
But, from Github's docs:
I'm going to do this manually |
Add integration_tests directory, with some basic tests. This was mostly added to
validate the work in #287 but was
ripped out to avoid merge conflicts.
Note that the integration tests specify a fixed port with a comment that says
that each port should be unique. I will do the work necessary to bind to
arbitrary ports in another PR - that way we can bind to port 0 and have the OS
select an open port for us.