Skip to content

Add ESM support#69

Closed
just-be-dev wants to merge 7 commits into
masterfrom
support-esm
Closed

Add ESM support#69
just-be-dev wants to merge 7 commits into
masterfrom
support-esm

Conversation

@just-be-dev

@just-be-dev just-be-dev commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

This PR updates the tsup configuration to generate esm builds.

📦 Published PR as canary version: 1.3.0--canary.69.6b085bb.0

✨ Test out this PR locally via:

npm install @oxide/design-system@1.3.0--canary.69.6b085bb.0
# or 
yarn add @oxide/design-system@1.3.0--canary.69.6b085bb.0

@david-crespo

Copy link
Copy Markdown
Collaborator

wat

image

@just-be-dev

Copy link
Copy Markdown
Contributor Author

I'm looking into it.

@just-be-dev

Copy link
Copy Markdown
Contributor Author

Auto bug is fixed. There was an issue with a new version of git but that was fixed upstream.

@david-crespo

Copy link
Copy Markdown
Collaborator

Tried it in docs and there may be one more change required around CSS. Or it could be a change required on the docs side. Here's the import.

vite v5.1.4 building for production...
✓ 56 modules transformed.
x Build failed in 171ms
Error: [vite:css] [postcss] Missing "./styles/dist/main.css" specifier in "@oxide/design-system" package
file: /Users/david/oxide/docs/app/styles/index.css?transform-only:undefined:NaN
    at e (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:25)
    at n (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:627)
    at o (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47384:1297)
    at resolveExportsOrImports (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:48061:20)
    at resolveDeepImport (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:48080:31)
    at tryNodeResolve (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47805:20)
    at Context.resolveId (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:47568:28)
    at Object.resolveId (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:50762:64)
    at async Object.<anonymous> (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:67768:21)
    at async Object.resolve (file:///Users/david/oxide/docs/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:31933:34) {
  code: 'PLUGIN_ERROR',
  loc: { file: undefined, line: undefined, column: NaN },
  pluginCode: "@import '@oxide/design-system/styles/dist/main.css';\n" +
    "@import '@oxide/design-system/styles/dist/yellow.css';\n" +
    "@import '@oxide/design-system/styles/dist/purple.css';\n" +
    "@import '@oxide/design-system/styles/dist/green.css';\n" +
    "@import '@oxide/design-system/styles/dist/blue.css';\n" +
    "@import '@oxide/design-system/components/dist/asciidoc.css';\n" +

// etc etc

@benjaminleonard

Copy link
Copy Markdown
Collaborator

Sorry ghost justin, we should have merged this

@benjaminleonard

Copy link
Copy Markdown
Collaborator

Retried in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants