Explicitly disallow overwriting in some cases#12
Closed
just-be-dev wants to merge 1 commit into
Closed
Conversation
ffcab60 to
15282af
Compare
Collaborator
|
Is the thing you miss in omicron that expectorate shows you the diff between actual and expected? What about using something like https://crates.io/crates/pretty_assertions If we do want to add something to expectorate for this case, I think we'd want the following properties:
Rather than a long name, perhaps something more definitive like Let me know if you think we should proceed or if pretty_assertions (or something like it) would be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In oxidecomputer/omicron#885 we explicitly opted not to use the assert contents method because we didn't want folks easily updating the file. While that's fine on the face of it, the error experience got objectively worse and has cost a non-trivial amount of debugging time. I'd put in a change to make the error message more friendly, but it broke half the assumptions of the test.
This PR sketches out a possible option where we have a method that explicitly doesn't perform overwriting. This is just a rough PoC, hoping to more generate conversation and figure out a direction.