Refactor in prep for gimlet/sidecar/psc variants of mgmt-gateway#738
Merged
Merged
Conversation
mkeeter
approved these changes
Aug 31, 2022
No functional changes. Moves usart logic out of main and into `mgs_handler` (which will become the gimlet-specific MGS handler).
jgallagher
force-pushed
the
mgmt-gateway-refactor-for-multiple-targets
branch
from
a0dc5d3 to
2b35c53
Compare
FawazTirmizi
pushed a commit
to rivosinc/hubris
that referenced
this pull request
Oct 3, 2022
…decomputer#738) No functional changes. Moves usart logic out of main and into `mgs_handler` (which will become the gimlet-specific MGS handler).
FawazTirmizi
pushed a commit
to rivosinc/hubris
that referenced
this pull request
Oct 3, 2022
…decomputer#738) No functional changes. Moves usart logic out of main and into `mgs_handler` (which will become the gimlet-specific MGS handler).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #737. No functional changes. Moves usart logic out of main and into
mgs_handler(which will become the gimlet-specific MGS handler in a subsequent PR), and renames a few methods. Review can be light.