use fill attribute instead of inline styles#4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on oxidecomputer/console#2142 I ran into
content-security-policyviolations due to inline styles. After finding out that React applies styles using thestyleattribute in a way that's compatible with CSP I tried to figure out what the violations were; it turns out all of them were due to thestyle=attribute in the SVG generated by this library.Using
filldirectly allows use of a strictercontent-security-policythat does not require allowingstyle-src: 'unsafe-inline'.(Tested by hand-patching
node_modules/@oxide/identicon/dist/identicon.jsin my console environment.)