scrimlet-reconcilers: add mgd BGP config reconciler#10565
Open
jgallagher wants to merge 5 commits into
Open
Conversation
internet-diglett
left a comment
internet-diglett
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good to me, just a few things to clarify
Comment on lines
+499
to
+505
| for (asn, config) in routers_to_create { | ||
| record_count!( | ||
| client.create_router(&config.to_mgd_router(*asn)).await, | ||
| routers_created, | ||
| format!("failed to create router with asn {asn}"), | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
In the case where we fail to delete children, we don't delete the router.
Likewise, could it be argued that if we fail to create the router, we shouldn't try to create its children?
Contributor
Author
There was a problem hiding this comment.
Yeah, that's fair. I didn't do that because it was a little messy (we'd have to keep track of which routers succeeded and which failed), and I assumed all those subsequent creations would also fail (more or less harmlessly). If you think it's worth doing I can see if I can make it not-too-messy.
Comment on lines
+1569
to
+1571
| // TODO-correctness Nexus historically used the port name as the | ||
| // group name. Does this matter? | ||
| group: port_name.clone(), |
Comment on lines
+1608
to
+1609
| src_addr: None, | ||
| src_port: None, |
Contributor
There was a problem hiding this comment.
Note for myself to plumb this through on #10572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a significant departure from the
sync_switch_configurationbg task's implementation of BGP config reconciliation. While adding proptests (which tend to hit unusual cases - here, it was "changing the ASN that owns a given peer"), we discovered:bgp_applyendpoint is a little buggy (the specific thing I hit is fixed by bgp_apply fixes maghemite#773)bgp_applyendpoint, because it takes the config for a single ASN, doesn't really allow for easy "remove the BGP config" or "change the config from ASN x to ASN y".Based on oxidecomputer/maghemite#773 (comment), this PR doesn't use the
bgp_applyendpoint, and instead makes multiple smaller calls to the various REST endpoints that comprise the BGP config. This would be much racier in Nexus, where different Nexus instances could be competing (potentially with out of date information if the config just changed), but here the one and only client is the local sled-agent, so we don't have to worry about that problem.