add flake patterns documentation#10577
Merged
emilyalbini merged 6 commits intoJun 10, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1
smklein
approved these changes
Jun 9, 2026
| - `test-utils/src/dev/poll.rs` has `wait_for_condition` and `wait_for_watch_channel_condition`. | ||
| - `nexus/test-utils/src/nexus_test.rs` has `wait_for_at_least_one_inventory_collection`. | ||
|
|
||
| **Example commits:** |
Collaborator
There was a problem hiding this comment.
I like the structure of linking to example commits here; I think that's a great idea
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Jun 9, 2026
Comment on lines
+64
to
+65
| // FIXME: replace XXXX with the merged commit hash of the test_repo_upload race-fix PR. | ||
| - https://github.com/oxidecomputer/omicron/commit/XXXX[`XXXX`] replaces `changed()` waits on the sled agents' delete-reconciler channels with a `generation >= pruned_generation` predicate. |
Contributor
Author
There was a problem hiding this comment.
Will update this once a PR I have in my local working copy lands.
Created using spr 1.3.6-beta.1
2 tasks
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
hawkw
pushed a commit
that referenced
this pull request
Jun 10, 2026
As discussed in the devx sync today, add a catalog of flake patterns as well as a Claude skill to review for them. [Rendered](https://github.com/oxidecomputer/omicron/blob/sunshowers/spr/add-flake-patterns-documentation/docs/flake-patterns.adoc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the devx sync today, add a catalog of flake patterns as well as a Claude skill to review for them.
Rendered