/v1/groups/{group}

[david-crespo]

We need this endpoint to power a group detail page in the console where we fetch the group by ID and display its name and the list of users in it.

As mentioned in a comment, groups have an external_id instead of a name and therefore don't implement ObjectIdentity, which makes doing a lookup by external ID a little less cute than lookup by name. external_id is unique per silo, so looking up by it with the silo implicit is perfectly possible in theory. However, unlike with Name, we do not (and probably cannot) enforce that the external_id of a group is not a UUID, which means our usual technique of falling back to name only once the thing fails to parse as a UUID does not work. If an external ID was a UUID, there would be no way to fetch a group by it because we would always assume it was one of our DB UUIDs.

One option would be to add a query param that allows the caller to specify that the given identifier is meant to be treated as the group external ID and not our DB ID. Another option, which we can do in a followup, is what @zephraph suggested in #2442 (comment): implement the external_id filter on the list endpoint instead. Because external_id is unique per silo, we know this will return either 1 or 0 results. It's a bit odd but it is conceptually consistent and requires no shenanigans.

[just-be-dev]

Pretty straight forward. 👍

[just-be-dev]

I wonder about the tag here. Isn't anything to be changed in this PR, but should silo scoped resources be listed in the silos tag?

[david-crespo]

I agree that it's weird. Perhaps even weirder: it seems to only be silo-scoped resources that get this tag. All the /system/silos/* endpoints for working with silos themselves are tagged system. We could probably stand to rework all the tags.

API operations found with tag "silos"
OPERATION ID                             URL PATH
group_list                               /groups
group_list_v1                            /v1/groups
group_view                               /v1/groups/{group}
policy_update                            /policy
policy_update_v1                         /v1/policy
policy_view                              /policy
policy_view_v1                           /v1/policy
user_list                                /users
user_list_v1                             /v1/user