Make dbinit.sql slightly less order-dependent#4288
Conversation
Hooray! I've only skimmed the PR but will ask anyway: If this is now legal, is the guideline in the schema README to add new tables only to the end of dbinit.sql still relevant? (If it's not, we should remove it and consider replacing it with guidance that db_metadata should always be last.) |
Sure thing, I just pushed a small update to the schema/crdb README. |
david-crespo
left a comment
There was a problem hiding this comment.
Looks good. I confirmed this change makes the schema tests pass in #4261.
bnaecker
left a comment
There was a problem hiding this comment.
I don't have enough context to really approve, but I don't see any issues!
This PR does two things:
SHOW CONSTRAINTSand information_schema.columna.is_nullable instead.Fixes #4286