Enable Updates for Floating IPs#5176
Merged
Merged
Conversation
david-crespo
reviewed
Mar 1, 2024
david-crespo
reviewed
Mar 1, 2024
david-crespo
reviewed
Mar 1, 2024
Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
david-crespo
reviewed
Mar 1, 2024
|
|
||
| fn assert_floating_ips_eq(first: &FloatingIp, second: &FloatingIp) { | ||
| assert_eq!(first.identity, second.identity); | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick, but I think this could be inlined. It's not doing enough — I expected it to compare all fields or something.
FelixMcFelix
approved these changes
Mar 1, 2024
FelixMcFelix
left a comment
FelixMcFelix
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for adding this in! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5016
This PR adds the ability to update names and descriptions for floating IPs.