[reconfigurator] Only provision to zpools with in-service physical disks#5375
[reconfigurator] Only provision to zpools with in-service physical disks#5375smklein wants to merge 4 commits into
Conversation
| "sled {}: remove expunged disks", | ||
| sled_id | ||
| )); | ||
| continue; |
There was a problem hiding this comment.
This seems to match the pattern below of "if we have any changes to make, do them and stop making further changes".
It seems plausible that we could remove an expunged zone and also do other allocations, but I'm not sure what our motivation is for "updating the blueprints via small steps", and wasn't confident enough to break that mold.
| Ok(Ensure::Added) | ||
| } | ||
|
|
||
| pub fn sled_ensure_zones_not_using_expunged_disks( |
There was a problem hiding this comment.
This method is currently acting as a no-op, because of the TODOs below.
But I think the right action here would be to add the zones to an "expunged zone" field within the blueprint?
@sunshowers , do you think #5211 will support that? Or will I need to add a BTreeSet to the BlueprintBuilder for each zone type that could be removed?
|
This PR is in merge hell and has been replaced by: |
Policy,SystemDescriptionto be aware of "what disks back zpools".sled_ensure_zones_not_using_expunged_disks, which can be used to remove zones using expunged disks.Partial fix of #5372