Skip to content

[reconfigurator] Only provision to zpools with in-service physical disks#5375

Closed
smklein wants to merge 4 commits into
mainfrom
reconfigurate-disk-expungement
Closed

[reconfigurator] Only provision to zpools with in-service physical disks#5375
smklein wants to merge 4 commits into
mainfrom
reconfigurate-disk-expungement

Conversation

@smklein

@smklein smklein commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator
  • Expand reconfigurator's Policy, SystemDescription to be aware of "what disks back zpools".
  • Updates callsites iterating over "all zpools" to consider whether or not they only want provisionable zpools, using active + in-service disks.
  • Adds a method sled_ensure_zones_not_using_expunged_disks, which can be used to remove zones using expunged disks.

Partial fix of #5372

"sled {}: remove expunged disks",
sled_id
));
continue;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to match the pattern below of "if we have any changes to make, do them and stop making further changes".

It seems plausible that we could remove an expunged zone and also do other allocations, but I'm not sure what our motivation is for "updating the blueprints via small steps", and wasn't confident enough to break that mold.

Ok(Ensure::Added)
}

pub fn sled_ensure_zones_not_using_expunged_disks(

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is currently acting as a no-op, because of the TODOs below.

But I think the right action here would be to add the zones to an "expunged zone" field within the blueprint?

@sunshowers , do you think #5211 will support that? Or will I need to add a BTreeSet to the BlueprintBuilder for each zone type that could be removed?

@andrewjstone andrewjstone self-assigned this Apr 12, 2024
@morlandi7 morlandi7 added this to the 8 milestone Apr 16, 2024
@smklein smklein assigned smklein and unassigned andrewjstone Apr 22, 2024
@smklein

smklein commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator Author

@smklein smklein closed this Apr 23, 2024
@smklein smklein deleted the reconfigurate-disk-expungement branch April 23, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants