[nexus] add BlueprintZoneDisposition::Expunged, make disposition a column in bp_omicron_zone#5438
Merged
sunshowers merged 5 commits intoApr 6, 2024
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
jgallagher
reviewed
Apr 5, 2024
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.nexus-db-model-make-disposition-a-column-in-bp_omicron_zone
to
main
sunshowers
changed the title
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Apr 6, 2024
andrewjstone
left a comment
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Great stuff @sunshowers
| let row_blueprint = DbBlueprint::from(blueprint); | ||
| let blueprint_id = row_blueprint.id; | ||
|
|
||
| // `Blueprint` stores the policy for each zone next to the zone itself. |
Contributor
There was a problem hiding this comment.
Pretty awesome how you can get rid of all this code without any additions now that the disposition is just a column on bp_omicron_zone :)
sunshowers
deleted the
sunshowers/spr/nexus-db-model-make-disposition-a-column-in-bp_omicron_zone
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (finally) adds a
BlueprintZoneDisposition::Expungedenum, along with database support for it by making the disposition a column.We also drop the
bp_omicron_zones_not_in_servicetable -- we don't bother to check for its contents because we aren't ever setting any zones as quiesced on customer sites currently.I've also included a Diesel extension to allow easily filtering against
BlueprintZoneDispositions, along with an example query for it.