Skip to content

Store comments as strongly-typed operations#5834

Merged
smklein merged 23 commits into
mainfrom
strong-typed-comments
Jun 6, 2024
Merged

Store comments as strongly-typed operations#5834
smklein merged 23 commits into
mainfrom
strong-typed-comments

Conversation

@smklein

@smklein smklein commented May 30, 2024

Copy link
Copy Markdown
Collaborator

Attempts to resolve the discussion in #5599 (comment) by using a strongly-typed Operation enum instead of arbitrary String comments.

@smklein smklein requested a review from sunshowers May 30, 2024 16:31
@smklein smklein marked this pull request as ready for review May 30, 2024 16:31
Base automatically changed from expunge-zones-with-expunged-disks to main May 30, 2024 16:34

@sunshowers sunshowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smklein smklein merged commit e48fd96 into main Jun 6, 2024
@smklein smklein deleted the strong-typed-comments branch June 6, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants