Make DataStore::instance_fetch_all less ugly#5891
Merged
Merged
Conversation
This commit rewrites the `DataStore::instance_fetch_all` query added in #5888 to perform two separate left joins with the `vmm` table, so that the result set only contains a single row. This is a bit more aesthetically pleasing than having to iterate over a multi-row result set, but should still return the same values. Thanks to @jgallagher and @luqmana for figuring out how to do the Diesel alias!
jgallagher
approved these changes
Jun 13, 2024
| let (active_vmm, target_vmm) = | ||
| diesel::alias!(vmm as active_vmm, vmm as target_vmm); | ||
| let vmm_selection = | ||
| <Vmm as Selectable<diesel::pg::Pg>>::construct_selection(); |
Contributor
There was a problem hiding this comment.
Great find! I looked for something like this hanging off of Alias and came up empty.
Member
Author
There was a problem hiding this comment.
Yeah, there was, as far as I can tell, no actual documentation explaining this usage I found it by looking at the implementation of as_select() and noticed that there was a comment on the Selectable trait saying that the return value from construct_selection() was "usually a tuple of fields".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit rewrites the
DataStore::instance_fetch_allquery added in#5888 to perform two separate left joins with the
vmmtable, so thatthe result set only contains a single row. This is a bit more
aesthetically pleasing than having to iterate over a multi-row result
set, but should still return the same values.
Thanks to @jgallagher and @luqmana for figuring out how to do the Diesel
alias!