[nexus] nicer OMDB status for instance_updater#6542
Merged
Conversation
While I was working on #6503, I became quite taken with the way @jmpesp had done the OMDB status for his region-replacement background tasks --- the approach of defining a struct in `nexus-types` representing the status JSON that both the background task implementation and OMDB could depend on seems much nicer than constructing an untyped JSON message and then deserializing it to a type that only exists in OMDB, because this way, OMDB and the background task implementation are kept in sync automatically. So, I thought it would be nice to also rework the `abandoned_vmm_reaper` task to use this style. This commit does that. While I was making this change, I also changed the status JSON to include a list of all errors that occurred during the task's activation, instead of just the last one, which will probably make it easier to debug any issues that come up. I also added some code for aligning the numeric columns in the OMDB output.
Depends on #6541. Similarly to #6541, this commit refactors the `instance_updater` background task's OMDB status implementation to use a shared Rust struct in `nexus-types` to represent the status JSON object. I also changed the status message to include a full list of errors that occurred, instead of just the most recent one and a count, and I made some tweaks to the output alignment in OMDB.
jmpesp
approved these changes
Sep 9, 2024
| instances with terminated active migrations: 0 | ||
| update sagas started: 0 | ||
| update sagas completed successfully: 0 | ||
| task explicitly disabled by config! |
Contributor
There was a problem hiding this comment.
I'm a little surprised to see this here - the Default policy should have disabled be false right?
Member
Author
There was a problem hiding this comment.
It's not disabled by default, but it is disabled explicitly in the test config file. Since this task is intended as a backstop to ensure update sagas are always run eventually, but it's not actually the primary mechanism that triggers update sagas, we disable it when running Nexus' integration tests, to make sure the other mechanisms for starting update sagas work in the happy path. See:
omicron/nexus/tests/config.test.toml
Lines 127 to 138 in a1534d7
hawkw
force-pushed
the
eliza/updater-omdb-nice
branch
from
2316680 to
245f167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #6541.
Similarly to #6541, this commit refactors the
instance_updaterbackground task's OMDB status implementation to use a shared Rust struct
in
nexus-typesto represent the status JSON object. I also changed thestatus message to include a full list of errors that occurred, instead
of just the most recent one and a count, and I made some tweaks to the
output alignment in OMDB.