[sled-agent] Support bundle storage api#6782
Merged
Merged
Conversation
This was referenced Oct 30, 2024
Merged
3 tasks
This was referenced Nov 20, 2024
smklein
commented
Nov 20, 2024
smklein
commented
Nov 20, 2024
Comment on lines
+700
to
+703
| /// Accesses the [SupportBundleManager] API. | ||
| pub(crate) fn as_support_bundle_storage(&self) -> SupportBundleManager<'_> { | ||
| SupportBundleManager::new(&self.log, self.storage()) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Rather than directly implementing the support bundle API as part of the Sled Agent, I split it into a different structure to make testing easier.
That's why I'm calling this function in the http_entrypoints
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| pub mod queries; |
Collaborator
Author
There was a problem hiding this comment.
FYI @papertigers - we both used the support_bundle.rs module, so I split your stuff into "queries" and my stuff into "storage". Hopefully the re-organization makes sense?
wfchandler
reviewed
Nov 21, 2024
wfchandler
left a comment
wfchandler
left a comment
Contributor
There was a problem hiding this comment.
Thanks @smklein, just a few small suggestions from me.
smklein
added a commit
that referenced
this pull request
Nov 21, 2024
This library is used as a part of #1599 , I'm pulling it out of #6782 to help make the diff smaller. This PR adds a `range-requests` crate for dropshot-based range requests. Heavily inspired by @jclulow 's work in https://github.com/oxidecomputer/buildomat/blob/main/download/src/lib.rs
Collaborator
Author
|
Thanks for the feedback! All the responses to review comments should be contained within e1e185b |
wfchandler
approved these changes
Nov 25, 2024
wfchandler
left a comment
wfchandler
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @smklein!
smklein
added a commit
that referenced
this pull request
Jan 13, 2025
PR 4 / ??? Adds a background task to manage support bundle lifecycle, and perform collection In this PR: - [x] Actually perform the work of collection in a background task - [x] Invoke the API from #6782 to store bundles - [x] Add tests to confirm the background task is working as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements raw bundle storage for support bundles.
In the future, I expect that Nexus will invoke these APIs to store and later access portions of storage bundles.
Fixes #1599