[nexus][support-bundles] Avoid looking at expunged datasets, zones#7325
Open
smklein wants to merge 3 commits into
Open
[nexus][support-bundles] Avoid looking at expunged datasets, zones#7325smklein wants to merge 3 commits into
smklein wants to merge 3 commits into
Conversation
smklein
commented
Jan 8, 2025
| CREATE UNIQUE INDEX IF NOT EXISTS one_bundle_per_dataset ON omicron.public.support_bundle ( | ||
| dataset_id | ||
| ); | ||
| ) WHERE dataset_id IS NOT NULL; |
Collaborator
Author
There was a problem hiding this comment.
This is necessary to avoid a full-table scan
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids accessing expunge zones and datasets from support bundle datastore methods. Instead,
it opts to read all valid {zones,datasets}, and consider everything not in that set as "in-need of replacement".
This means that expunged and pruned {zones,datasets} will both be treated the same. Added a test for this
behavior with a dataset that gets fully removed, skipping the expungement stage.
Fixes #7319