dpd can be server-side-versioned#7848
Merged
Merged
Conversation
hawkw
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFD 532 talks about categorizing each internal Dropshot/Progenitor/OpenAPI API as either "lockstep" (server always deployed in sync with clients), "server-side-only-versioned" (server is always newer than clients), or "client-side-versioned" (server may be newer or older). It's always best to be lockstep or server-side-only because there's annoying work for client-side-versioned that has to be done for every change to these APIs.
#7138 took a first swing at assigning these determinations for each API. At the time, there was a circular dependency between sled agent and dpd, which meant one of them had to be client-side-versioned. I picked dpd to be client-side-versioned fairly arbitrarily (knowing the sled agent API was complex and it'd help to be server-side-only-versioned). But the dependency from dpd on sled-agent has since been removed (by oxidecomputer/dendrite#1031) and now both can be server-side-versioned.