remove apparently unused code blocking Nexus startup#7850
Merged
Conversation
Collaborator
Author
|
It looks like maybe this was used prior to #4822 but not after that? |
Contributor
|
@davepacheco I don't see where we need this code anymore either. I believe was left in place because we didn't have certain things available in our test suite at the time, but that seems to have been resolved a log ago. |
internet-diglett
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure yet if this is correct. But we've had a number of issues where Nexus startup was blocked on being able to establish connectivity to Dendrite and/or MGD. But it looks at first glance like this code is checking all this, assembling maps of clients, and then not using them. This PR removes it.
See: #7779, #7739, #5092