Revert "DNS servers should have NS and SOA records (#8047)"#8272
Closed
iximeow wants to merge 1 commit into
Closed
Revert "DNS servers should have NS and SOA records (#8047)"#8272iximeow wants to merge 1 commit into
iximeow wants to merge 1 commit into
Conversation
iximeow
commented
Jun 4, 2025
This reverts commit 3e68262. The change in 3e68262 does not handle upgrade sufficiently: when internal DNS starts it tries to parse a `CurrentConfig` from a json blob describing the previous server version's config. As Angela found on dogfood, this means internal DNS will fail to start with an error about "missing field `serial` at line 1 column ..." We're reverting this to unblock dogfood, but will add this back in with additional logic to handle this case.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e68262.
The change in 3e68262 does not handle upgrade sufficiently: when internal DNS starts it tries to parse a
CurrentConfigfrom a json blob describing the previous server version's config. As Angela found on dogfood, this means internal DNS will fail to start with an error about "missing fieldserialat line 1 column ...". Internal DNS failing to start means we'll never get Nexus up, so we can't Reconfigurator our way to a new blueprint and the desired DNS configuration with a serial number.We're reverting this to unblock dogfood, but will add this back in with additional logic to handle this case.