Skip to content

Advertise MAC_CAPAB_OVERLAY #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FelixMcFelix merged 1 commit into from
Jan 14, 2026
Merged

Advertise MAC_CAPAB_OVERLAY #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions xde/src/mac/sys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ pub enum mac_capab_t {
MAC_CAPAB_NO_ZCOPY = 0x00100000, /* boolean only, no data */
MAC_CAPAB_LEGACY = 0x00200000, /* data is mac_capab_legacy_t */
MAC_CAPAB_VRRP = 0x00400000, /* data is mac_capab_vrrp_t */
MAC_CAPAB_OVERLAY = 0x00800000, /* boolean only, no data */
MAC_CAPAB_TRANSCEIVER = 0x01000000, /* mac_capab_transciever_t */
MAC_CAPAB_LED = 0x02000000, /* data is mac_capab_led_t */
}
Expand Down
7 changes: 7 additions & 0 deletions xde/src/xde.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3096,6 +3096,13 @@ unsafe extern "C" fn xde_mc_getcapab(

boolean_t::B_TRUE
}
// We *are* an overlay device, and this helpfully convinces MAC
// to give us eight softrings without advertising MAC_CAPAB_RINGS
// (and pretending to have 8 physical rings, get polled by an SRS...).
//
// We want, in future, to dynamically size the softring count of
// an XDE port to 1-to-1 match the number of viona queues above it.
mac::mac_capab_t::MAC_CAPAB_OVERLAY => boolean_t::B_TRUE,
_ => boolean_t::B_FALSE,
}
}
Expand Down