Generate per-method transformResponse from schema#231
Closed
david-crespo wants to merge 4 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
david-crespo
force-pushed
the
transform-response
branch
from
e5782ca to
06aad71
Compare
david-crespo
force-pushed
the
transform-response
branch
from
06aad71 to
0b66ea9
Compare
david-crespo
changed the title
transformResponse from schematransformResponse from schema
Collaborator
Author
|
I kind of hate it, but at this point it works well enough that all the e2e tests pass in console, so at least it's not completely broken. |
Collaborator
Author
|
@charliepark and I talked through this and we're going to close it. Useful prototype if we want to do per-endpoint transforms in the future, but for now we can just deal with the one BigInt value by hand in the console. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230. Prototype. The point of this is to add support for the BigInts in oxidecomputer/omicron#5258, but also make our runtime transformation smarter in general.