prettier -> oxfmt#359
Merged
Merged
Conversation
fix(generator): newline after ( in union types for oxfmt/prettier parity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using prettier in three ways:
d7d2269 gets rid of the third one: turns out the snapshots are perfectly readable even without being formatted. The other two were straightforward to convert to oxfmt. The changes in the generator source are all just trailing commas. We were using two different version of prettier before, and the one on the source had trailing commas
es5, and the one on the generated output has trailing commasall. So to make it consistent and avoid any changes to the generated client output, I went withall.