Allow consumers to specify additional derive macros for generated types#21
Merged
Conversation
|
First attempt at integrating (just adding a "Cargo.toml" patch for progenitor to use this branch): I think the issue is that the "FOO-client" crates don't depend on schemars, but they would need to for this PR to work correctly. I can go add that dependency (manually) and try once more. |
|
Adding the |
This was referenced Jan 7, 2022
|
The two linked PRs show the necessary changes. I would have used cargo patch to point to this branch, but that doesn't seem possible due to rust-lang/cargo#5478. In the meantime, I just patched with local files to show what changes are incurred. |
structured generate_api! macro general updates and cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This structures the parameters to the
generate_api!macro (incompatibly) and allows for extra derive macros such asJsonSchema.---8<--- old ---8<---
@smklein let me know if this works for you
I'm going to poke at two things