PHD: allow a single test case to launch multiple VMs#186
Merged
Conversation
pfmooney
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add affordances for running multiple VMs in a single PHD test case. This largely involves making the VM factory hand out Dropshot/VNC server ports from a range instead of assuming that all VMs will use ports 9000/5900.
Add a multiple-VM smoke test. This test revealed a few tracing defects in the framework that this change aims to fix (e.g. some span usage bugs that made it hard to tell which serial console output came from which VM).
Finally, delete the
unamesmoke test, since it was originally just a proof-of-concept for the framework, and there's not much reason to spend time running it when other tests are online.Closes #172.