Support illumos#15143 data and vCPU pause/resume#367
Merged
Conversation
gjcolombo
approved these changes
Apr 7, 2023
gjcolombo
left a comment
gjcolombo
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a couple of nits and one possible test improvement. Thanks for putting this together!
With the integration of illumos#15143, additional pending interrupt and exception state for guest vCPUs is exposed to userspace. In order to take a consistent snapshot of said state, as well as the guest devices emulated in-kernel, propolis-server needs to issue VM_PAUSE requests prior to exporting or importing state, and VM_RESUME requests when starting a VM after a migration. Importation of the "new" vCPU state is guarded with a version check for now, so that propolis continues to work on hosts which have not yet updated to bits featuring illumos#15143.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the integration of illumos#15143, additional pending interrupt and exception state for guest vCPUs is exposed to userspace. In order to take a consistent snapshot of said state, as well as the guest devices emulated in-kernel, propolis-server needs to issue VM_PAUSE requests prior to exporting or importing state, and VM_RESUME requests when starting a VM after a migration.
Importation of the "new" vCPU state is guarded with a version check for now, so that propolis continues to work on hosts which have not yet updated to bits featuring illumos#15143.
Closes #291 as well.