Hover card DX#55
Merged
Merged
Conversation
This reverts commit 249629c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls three useful things up from the docs site.
plainText(inlines)— flattens an inline AST to visible plain text, entity-decoded. Merges the app'sinlineText+decodeEntities. The walk is coupled to theInlineNodeunion and the library owns the decision to leave numeric entities (’) in text nodes, so it should own resolving them on the way to plain text. The per-node switch is exhaustive with aneverdefault — adding a node type is now a compile error here rather than a silent drop (the bug that motivated this: an app-side copy broke when the union gainedraw). Helpful for something like a hover card or search section preview.Blockunion fix — addsListBlock,DListBlock,ListItemBlock, andCellto the publicBlockunion.items/cell shapes are now reachable without casting (block as { items?: … }).findSection(blocks, id)— depth-first find-by-id over the block AST, descending through child blocks, list items, and table cells.Canary:
npm install @oxide/react-asciidoc@2.0.0-canary.bd2aad7