[2/n] be more rigorous about when events are recorded in-memory vs durably#461
Open
Conversation
Created using spr 1.3.6-beta.1
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes at least three different races, all related to #17.
Previously, the main executor loop and the worker task both updated parts of in-memory state separately. During this brief window of divergence, it was possible to observe torn state in a few different ways. See the included tests for some reproductions.
With this change, we make it so that:
For start events, in-memory state is updated before durable state. For completion events, durable state is updated before in-memory state. This seems like the most reasonable way to do things.
I had to introduce some additional injection infrastructure so tests can reproduce the races deterministically.
See the comments on #17 for detailed design discussion.