[DEV-3677] Refactor api layer for api data model by tommaso1 · Pull Request #2056 · pagopa/developer-portal

tommaso1 · 2026-02-24T16:19:10Z

List of Changes

Refactor api layer for api data model

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Chore (nothing changes by a user perspective)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

changeset-bot · 2026-02-24T16:19:17Z

🦋 Changeset detected

Latest commit: c038fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
nextjs-website	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

This PR refactors the Next.js website “API Data” data-access layer by moving Strapi fetching/mapping for API list pages and API detail pages into dedicated repository modules, and by centralizing buildEnv creation.

Changes:

Extracted buildEnv initialization into src/lib/buildEnv.ts and reused it from cmsApi.
Introduced apiDataListPages/ and apiDataList/ modules (types, fetchers, mappers, repositories) and updated route pages/utilities to consume them.
Removed legacy API-data-related functions from cmsApi/api and added a changeset.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
apps/nextjs-website/src/lib/cmsApi.ts	Switches to shared `buildEnv` import; removes legacy API data functions.
apps/nextjs-website/src/lib/buildEnv.ts	New shared BuildEnv initialization module.
apps/nextjs-website/src/lib/apiDataListPages/types.ts	New types for API data list pages + template prop re-export.
apps/nextjs-website/src/lib/apiDataListPages/fetcher.ts	New Strapi fetcher for API data list pages using `buildEnv`.
apps/nextjs-website/src/lib/apiDataListPages/mapper.ts	New mapper from Strapi API list pages to UI props.
apps/nextjs-website/src/lib/apiDataListPages/index.ts	Repository API for retrieving API list pages.
apps/nextjs-website/src/lib/apiDataList/types.ts	New types module for API data list + page props re-export.
apps/nextjs-website/src/lib/apiDataList/fetcher.ts	New Strapi fetcher for API data entries using `buildEnv`.
apps/nextjs-website/src/lib/apiDataList/mapper.ts	New mapper for API data entries to route page props.
apps/nextjs-website/src/lib/apiDataList/index.ts	Repository API for retrieving API data entries.
apps/nextjs-website/src/lib/api.ts	Updates API params generation to use the new repository.
apps/nextjs-website/src/app/[locale]/[productSlug]/api/page.tsx	Swaps to repository-based lookup for the API list page.
apps/nextjs-website/src/app/[locale]/[productSlug]/api/[apiDataSlug]/page.tsx	Swaps to repository-based lookup for API detail pages.
.changeset/soft-rats-cover.md	Records a patch-level changeset for the refactor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T09:34:00Z

apps/nextjs-website/src/app/[locale]/[productSlug]/api/page.tsx

 const ApiDataListPage = async (props: { params: Promise<Params> }) => {
  const { locale, productSlug } = await props.params;
-  const apiDataListPageProps = await getApiDataListPages(locale, productSlug);
+  const apiDataListPageProps =
+    await ApiDataListPagesRepository.getByProductSlug(locale, productSlug);



After switching to ApiDataListPagesRepository.getByProductSlug, this page still has no explicit 404/missing-data handling. If apiDataListPageProps is undefined, the component currently renders nothing; return the locale not-found page or call notFound() when the lookup fails.

Copilot · 2026-02-25T09:34:00Z

apps/nextjs-website/src/app/[locale]/[productSlug]/api/[apiDataSlug]/page.tsx

+  if (!ApiDataProps) {
+    // eslint-disable-next-line functional/no-throw-statements
+    throw new Error('Failed to fetch data');
+  }


Throwing a generic error here turns a missing API entry into a 500. Other routes in this app return the locale PageNotFound/notFound() for missing content; consider doing the same in generateMetadata to produce a 404 instead of crashing the request.

I agree with the LLM here, I would use the same logic use elsewhere to address the missing data

Copilot · 2026-02-25T09:34:00Z

apps/nextjs-website/src/app/[locale]/[productSlug]/api/[apiDataSlug]/page.tsx

+  if (!apiDataProps) {
+    // eslint-disable-next-line functional/no-throw-statements
+    throw new Error('Failed to fetch data');
+  }


Same as above: throwing here will surface as a 500 error for unknown slugs. Prefer returning <PageNotFound /> (as you already do later) or using notFound() so unknown API slugs correctly render a 404.

Same as here #2056 (comment)

Copilot · 2026-02-25T09:34:01Z

apps/nextjs-website/src/lib/apiDataListPages/mapper.ts

+import { makeBannerLinkProps } from '@/lib/strapi/makeProps/makeBannerLink';
+import { makeBaseProductWithoutLogoProps } from '@/lib/strapi/makeProps/makeProducts';
+import { StrapiApiDataListPages, ApiDataListPageTemplateProps } from './types';
+import { compact } from 'lodash';
+import { StrapiBaseApiData } from '@/lib/strapi/types/apiDataList';
+
+function makeApiDataListPageCard(
+  locale: string,
+  item: StrapiBaseApiData,
+  slug: string
+) {
+  if (!item.attributes.apiRestDetail && !item.attributes.apiSoapDetail) {
+    console.error(
+      `Error while processing API Data with title "${item.attributes.title}": missing API details. Skipping...`
+    );
+    return null;
+  }
+
+  if (
+    !item.attributes.apiRestDetail?.slug &&
+    !item.attributes.apiSoapDetail?.slug
+  ) {
+    console.error(`
+      Error while processing API Data with title "${item.attributes.title}": missing API slug. Skipping...`);
+    return null;
+  }
+
+  return {
+    labels: [
+      {
+        label: item.attributes.apiSoapDetail ? 'SOAP' : 'REST',
+      },
+    ].filter((label) => !!label.label),
+    title: item?.attributes?.title,
+    text: item?.attributes?.description || '',
+    icon: item?.attributes?.icon?.data?.attributes.url || undefined,
+    href: `/${locale}/${slug}/api/${
+      item.attributes.apiRestDetail
+        ? item.attributes.apiRestDetail?.slug
+        : item.attributes.apiSoapDetail?.slug
+    }`,
+    tags: item.attributes.tags.data?.map((tag) => tag.attributes) || [],
+  };
+}
+
+export function mapApiDataListPages(
+  locale: string,
+  strapiApiDataListPages: StrapiApiDataListPages
+): ReadonlyArray<ApiDataListPageTemplateProps> {
+  return compact(
+    strapiApiDataListPages.data.map(({ attributes }) => {
+      const slug = attributes.product.data?.attributes.slug;
+      if (!slug) {
+        console.error(
+          `Error while processing API Data List Page with title "${attributes.title}": missing product slug. Skipping...`
+        );
+        return null;
+      }
+
+      // eslint-disable-next-line functional/no-try-statements
+      try {
+        const product = makeBaseProductWithoutLogoProps(
+          locale,
+          attributes.product.data
+        );
+        return {
+          ...attributes,
+          hero: {
+            title: attributes.title,
+            subtitle: attributes.description || '',
+          },
+          product,
+          apiDetailSlugs: compact(
+            attributes.apiData.data.map(({ attributes }) =>
+              attributes.apiRestDetail
+                ? attributes.apiRestDetail.slug
+                : attributes.apiSoapDetail?.slug
+            )
+          ),
+          cards: compact(
+            attributes.apiData.data.map((item) =>
+              makeApiDataListPageCard(locale, item, slug)
+            )
+          ),
+          bannerLinks: attributes.bannerLinks.map(makeBannerLinkProps),
+          seo: attributes.seo,
+          updatedAt: attributes.updatedAt,
+          enableFilters: attributes.enableFilters,
+          tags: product.tags,
+        };
+      } catch (error) {
+        // eslint-disable-next-line functional/no-expression-statements
+        console.error(
+          `Error while processing API Data List Page with title "${attributes.title}":`,
+          error,
+          'Skipping...'
+        );
+        return null;
+      }
+    })
+  );


This mapping logic appears to be a near-copy of lib/strapi/makeProps/makeApiDataListPages.ts (which already has dedicated unit tests). To avoid duplicated logic drifting and losing coverage, consider reusing the existing makeApiDataListPagesProps implementation (or porting its tests to cover mapApiDataListPages).

Suggested change

import { makeBannerLinkProps } from '@/lib/strapi/makeProps/makeBannerLink';

import { makeBaseProductWithoutLogoProps } from '@/lib/strapi/makeProps/makeProducts';

import { StrapiApiDataListPages, ApiDataListPageTemplateProps } from './types';

import { compact } from 'lodash';

import { StrapiBaseApiData } from '@/lib/strapi/types/apiDataList';

function makeApiDataListPageCard(

locale: string,

item: StrapiBaseApiData,

slug: string

) {

if (!item.attributes.apiRestDetail && !item.attributes.apiSoapDetail) {

console.error(

`Error while processing API Data with title "${item.attributes.title}": missing API details. Skipping...`

);

return null;

}

if (

!item.attributes.apiRestDetail?.slug &&

!item.attributes.apiSoapDetail?.slug

) {

console.error(`

Error while processing API Data with title "${item.attributes.title}": missing API slug. Skipping...`);

return null;

}

return {

labels: [

{

label: item.attributes.apiSoapDetail ? 'SOAP' : 'REST',

},

].filter((label) => !!label.label),

title: item?.attributes?.title,

text: item?.attributes?.description || '',

icon: item?.attributes?.icon?.data?.attributes.url || undefined,

href: `/${locale}/${slug}/api/${

item.attributes.apiRestDetail

? item.attributes.apiRestDetail?.slug

: item.attributes.apiSoapDetail?.slug

}`,

tags: item.attributes.tags.data?.map((tag) => tag.attributes) || [],

};

}

export function mapApiDataListPages(

locale: string,

strapiApiDataListPages: StrapiApiDataListPages

): ReadonlyArray<ApiDataListPageTemplateProps> {

return compact(

strapiApiDataListPages.data.map(({ attributes }) => {

const slug = attributes.product.data?.attributes.slug;

if (!slug) {

console.error(

`Error while processing API Data List Page with title "${attributes.title}": missing product slug. Skipping...`

);

return null;

}

// eslint-disable-next-line functional/no-try-statements

try {

const product = makeBaseProductWithoutLogoProps(

locale,

attributes.product.data

);

return {

...attributes,

hero: {

title: attributes.title,

subtitle: attributes.description || '',

},

product,

apiDetailSlugs: compact(

attributes.apiData.data.map(({ attributes }) =>

attributes.apiRestDetail

? attributes.apiRestDetail.slug

: attributes.apiSoapDetail?.slug

)

),

cards: compact(

attributes.apiData.data.map((item) =>

makeApiDataListPageCard(locale, item, slug)

)

),

bannerLinks: attributes.bannerLinks.map(makeBannerLinkProps),

seo: attributes.seo,

updatedAt: attributes.updatedAt,

enableFilters: attributes.enableFilters,

tags: product.tags,

};

} catch (error) {

// eslint-disable-next-line functional/no-expression-statements

console.error(

`Error while processing API Data List Page with title "${attributes.title}":`,

error,

'Skipping...'

);

return null;

}

})

);

import { makeApiDataListPagesProps } from '@/lib/strapi/makeProps/makeApiDataListPages';

import { StrapiApiDataListPages, ApiDataListPageTemplateProps } from './types';

export function mapApiDataListPages(

locale: string,

strapiApiDataListPages: StrapiApiDataListPages

): ReadonlyArray<ApiDataListPageTemplateProps> {

return makeApiDataListPagesProps(locale, strapiApiDataListPages);

Same as the other section.
I will not follow the copilot suggestion here, but this comment raises some questions about the existing tests.

There are some already existing tests that are related to the make function apps/nextjs-website/src/lib/strapi/tests/makeApiDataListPages.test.ts . I will move this test inside the apiDataList folder alongside other files and refactor that test to use the new mapper function.

apps/nextjs-website/src/app/[locale]/[productSlug]/api/page.tsx

Copilot · 2026-02-25T09:34:02Z

apps/nextjs-website/src/lib/apiDataList/mapper.ts

+
+export async function mapApiDataList(
+  locale: string,
+  strapiApiDataList: StrapiApiDataList
+): Promise<ReadonlyArray<ApiDataPageProps>> {
+  const list = compact(
+    await Promise.all(
+      strapiApiDataList.data
+        .filter(
+          (apiPage) =>
+            apiPage.attributes.apiRestDetail || apiPage.attributes.apiSoapDetail
+        )
+        .map(async ({ attributes }) => {
+          if (!attributes.apiRestDetail && !attributes.apiSoapDetail) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing API details. Skipping...`
+            );
+            return null;
+          }
+          const apiDataSlug =
+            attributes.apiRestDetail?.slug ||
+            attributes.apiSoapDetail?.slug ||
+            '';
+          if (!apiDataSlug) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing API slug. Skipping...`
+            );
+            return null;
+          }
+
+          if (!attributes.product.data) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing product data. Skipping...`
+            );
+            return null;
+          }
+
+          // eslint-disable-next-line functional/no-try-statements
+          try {
+            const product = makeBaseProductWithoutLogoProps(
+              locale,
+              attributes.product.data
+            );
+            return {
+              ...attributes,
+              product,
+              apiType: attributes.apiRestDetail ? 'rest' : 'soap',
+              apiDataSlug: apiDataSlug,
+              restApiSpecUrls: attributes.apiRestDetail
+                ? [
+                    ...attributes.apiRestDetail.specUrls.map((spec) => ({
+                      ...spec,
+                    })),
+                  ]
+                : [],
+              apiSoapUrl: attributes.apiSoapDetail?.repositoryUrl,
+              specUrlsName: attributes.title,
+              apiSoapUrlList: attributes.apiSoapDetail
+                ? await makeApiSoapUrlList(
+                    locale,
+                    attributes.apiSoapDetail.dirName
+                  )
+                : [],
+              bannerLinks:
+                attributes.bannerLinks.length > 0
+                  ? attributes.bannerLinks.map(makeBannerLinkProps)
+                  : attributes.product.data.attributes.bannerLinks?.map(
+                      makeBannerLinkProps
+                    ),
+              seo: attributes.seo,
+            } satisfies ApiDataPageProps;
+          } catch (error) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}":`,
+              error,
+              'Skipping...'
+            );
+            return null;
+          }
+        })
+    )
+  );
+  return Promise.all(list);


This mapping logic appears to be a near-copy of lib/strapi/makeProps/makeApiDataList.ts (which already has unit tests under lib/strapi/__tests__/makeApiDataList.test.ts). Consider reusing the existing implementation or porting those tests to cover mapApiDataList so the refactor doesn’t reduce confidence in the transformation behavior.

Suggested change

export async function mapApiDataList(

locale: string,

strapiApiDataList: StrapiApiDataList

): Promise<ReadonlyArray<ApiDataPageProps>> {

const list = compact(

await Promise.all(

strapiApiDataList.data

.filter(

(apiPage) =>

apiPage.attributes.apiRestDetail || apiPage.attributes.apiSoapDetail

)

.map(async ({ attributes }) => {

if (!attributes.apiRestDetail && !attributes.apiSoapDetail) {

console.error(

`Error while processing API Data with title "${attributes.title}": missing API details. Skipping...`

);

return null;

}

const apiDataSlug =

attributes.apiRestDetail?.slug ||

attributes.apiSoapDetail?.slug ||

'';

if (!apiDataSlug) {

console.error(

`Error while processing API Data with title "${attributes.title}": missing API slug. Skipping...`

);

return null;

}

if (!attributes.product.data) {

console.error(

`Error while processing API Data with title "${attributes.title}": missing product data. Skipping...`

);

return null;

}

// eslint-disable-next-line functional/no-try-statements

try {

const product = makeBaseProductWithoutLogoProps(

locale,

attributes.product.data

);

return {

...attributes,

product,

apiType: attributes.apiRestDetail ? 'rest' : 'soap',

apiDataSlug: apiDataSlug,

restApiSpecUrls: attributes.apiRestDetail

? [

...attributes.apiRestDetail.specUrls.map((spec) => ({

...spec,

})),

]

: [],

apiSoapUrl: attributes.apiSoapDetail?.repositoryUrl,

specUrlsName: attributes.title,

apiSoapUrlList: attributes.apiSoapDetail

? await makeApiSoapUrlList(

locale,

attributes.apiSoapDetail.dirName

)

: [],

bannerLinks:

attributes.bannerLinks.length > 0

? attributes.bannerLinks.map(makeBannerLinkProps)

: attributes.product.data.attributes.bannerLinks?.map(

makeBannerLinkProps

),

seo: attributes.seo,

} satisfies ApiDataPageProps;

} catch (error) {

console.error(

`Error while processing API Data with title "${attributes.title}":`,

error,

'Skipping...'

);

return null;

}

})

)

);

return Promise.all(list);

import { makeApiDataList as makeStrapiApiDataList } from '@/lib/strapi/makeProps/makeApiDataList';

export async function mapApiDataList(

locale: string,

strapiApiDataList: StrapiApiDataList

): Promise<ReadonlyArray<ApiDataPageProps>> {

return makeStrapiApiDataList(locale, strapiApiDataList);

I will not follow the copilot suggestion here, but this comment raises some questions about the existing tests.

There are some already existing tests that are related to the make function apps/nextjs-website/src/lib/strapi/__tests__/makeApiDataList.test.ts . I will move this test inside the apiDataList folder alongside other files and refactor that test to use the new mapper function.

apps/nextjs-website/src/lib/apiDataListPages/mapper.ts

apps/nextjs-website/src/lib/apiDataList/types.ts

apps/nextjs-website/src/lib/apiDataListPages/types.ts

apps/nextjs-website/src/lib/apiDataList/mapper.ts

Sebastiano-Bertolin · 2026-02-25T09:53:54Z

@tommaso1
"You know, this is, excuse me, a damn fine PR!" mod cit.

MarcoPonchia · 2026-03-02T14:23:57Z

apps/nextjs-website/src/lib/apiDataListPages/types.ts

+export type {
+  ApiDataListPages,
+  ApiDataListPage,
+  ApiDataListPageWithoutProduct,
+  ApiDataListPageTemplateProps,
+};


Instead of exporting here the types, why not move here the whole type definition? So the previous apps/nextjs-website/src/lib/strapi/types/apiDataListPages.ts can be deleted, and all types will be centralized here?

MarcoPonchia · 2026-03-02T14:24:30Z

apps/nextjs-website/src/lib/apiDataList/types.ts

+} from '@/lib/strapi/types/apiDataList';
+import { ApiDataPageProps } from '@/app/[locale]/[productSlug]/api/[apiDataSlug]/page';
+
+export type { ApiDataList, ApiData, ApiDataPageProps };


Instead of exporting here the types, why not move here the whole type definition? So the previous apps/nextjs-website/src/lib/strapi/types/apiDataList.ts can be deleted, and all types will be centralized here?

MarcoPonchia · 2026-03-02T14:41:24Z

apps/nextjs-website/src/lib/apiDataList/mapper.ts

+
+export async function mapApiDataList(
+  locale: string,
+  strapiApiDataList: StrapiApiDataList
+): Promise<ReadonlyArray<ApiDataPageProps>> {
+  const list = compact(
+    await Promise.all(
+      strapiApiDataList.data
+        .filter(
+          (apiPage) =>
+            apiPage.attributes.apiRestDetail || apiPage.attributes.apiSoapDetail
+        )
+        .map(async ({ attributes }) => {
+          if (!attributes.apiRestDetail && !attributes.apiSoapDetail) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing API details. Skipping...`
+            );
+            return null;
+          }
+          const apiDataSlug =
+            attributes.apiRestDetail?.slug ||
+            attributes.apiSoapDetail?.slug ||
+            '';
+          if (!apiDataSlug) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing API slug. Skipping...`
+            );
+            return null;
+          }
+
+          if (!attributes.product.data) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}": missing product data. Skipping...`
+            );
+            return null;
+          }
+
+          // eslint-disable-next-line functional/no-try-statements
+          try {
+            const product = makeBaseProductWithoutLogoProps(
+              locale,
+              attributes.product.data
+            );
+            return {
+              ...attributes,
+              product,
+              apiType: attributes.apiRestDetail ? 'rest' : 'soap',
+              apiDataSlug: apiDataSlug,
+              restApiSpecUrls: attributes.apiRestDetail
+                ? [
+                    ...attributes.apiRestDetail.specUrls.map((spec) => ({
+                      ...spec,
+                    })),
+                  ]
+                : [],
+              apiSoapUrl: attributes.apiSoapDetail?.repositoryUrl,
+              specUrlsName: attributes.title,
+              apiSoapUrlList: attributes.apiSoapDetail
+                ? await makeApiSoapUrlList(
+                    locale,
+                    attributes.apiSoapDetail.dirName
+                  )
+                : [],
+              bannerLinks:
+                attributes.bannerLinks.length > 0
+                  ? attributes.bannerLinks.map(makeBannerLinkProps)
+                  : attributes.product.data.attributes.bannerLinks?.map(
+                      makeBannerLinkProps
+                    ),
+              seo: attributes.seo,
+            } satisfies ApiDataPageProps;
+          } catch (error) {
+            console.error(
+              `Error while processing API Data with title "${attributes.title}":`,
+              error,
+              'Skipping...'
+            );
+            return null;
+          }
+        })
+    )
+  );
+  return Promise.all(list);


I will not follow the copilot suggestion here, but this comment raises some questions about the existing tests.

There are some already existing tests that are related to the make function apps/nextjs-website/src/lib/strapi/__tests__/makeApiDataList.test.ts . I will move this test inside the apiDataList folder alongside other files and refactor that test to use the new mapper function.

MarcoPonchia · 2026-03-02T14:46:39Z

apps/nextjs-website/src/lib/apiDataListPages/mapper.ts

+import { makeBannerLinkProps } from '@/lib/strapi/makeProps/makeBannerLink';
+import { makeBaseProductWithoutLogoProps } from '@/lib/strapi/makeProps/makeProducts';
+import { StrapiApiDataListPages, ApiDataListPageTemplateProps } from './types';
+import { compact } from 'lodash';
+import { StrapiBaseApiData } from '@/lib/strapi/types/apiDataList';
+
+function makeApiDataListPageCard(
+  locale: string,
+  item: StrapiBaseApiData,
+  slug: string
+) {
+  if (!item.attributes.apiRestDetail && !item.attributes.apiSoapDetail) {
+    console.error(
+      `Error while processing API Data with title "${item.attributes.title}": missing API details. Skipping...`
+    );
+    return null;
+  }
+
+  if (
+    !item.attributes.apiRestDetail?.slug &&
+    !item.attributes.apiSoapDetail?.slug
+  ) {
+    console.error(`
+      Error while processing API Data with title "${item.attributes.title}": missing API slug. Skipping...`);
+    return null;
+  }
+
+  return {
+    labels: [
+      {
+        label: item.attributes.apiSoapDetail ? 'SOAP' : 'REST',
+      },
+    ].filter((label) => !!label.label),
+    title: item?.attributes?.title,
+    text: item?.attributes?.description || '',
+    icon: item?.attributes?.icon?.data?.attributes.url || undefined,
+    href: `/${locale}/${slug}/api/${
+      item.attributes.apiRestDetail
+        ? item.attributes.apiRestDetail?.slug
+        : item.attributes.apiSoapDetail?.slug
+    }`,
+    tags: item.attributes.tags.data?.map((tag) => tag.attributes) || [],
+  };
+}
+
+export function mapApiDataListPages(
+  locale: string,
+  strapiApiDataListPages: StrapiApiDataListPages
+): ReadonlyArray<ApiDataListPageTemplateProps> {
+  return compact(
+    strapiApiDataListPages.data.map(({ attributes }) => {
+      const slug = attributes.product.data?.attributes.slug;
+      if (!slug) {
+        console.error(
+          `Error while processing API Data List Page with title "${attributes.title}": missing product slug. Skipping...`
+        );
+        return null;
+      }
+
+      // eslint-disable-next-line functional/no-try-statements
+      try {
+        const product = makeBaseProductWithoutLogoProps(
+          locale,
+          attributes.product.data
+        );
+        return {
+          ...attributes,
+          hero: {
+            title: attributes.title,
+            subtitle: attributes.description || '',
+          },
+          product,
+          apiDetailSlugs: compact(
+            attributes.apiData.data.map(({ attributes }) =>
+              attributes.apiRestDetail
+                ? attributes.apiRestDetail.slug
+                : attributes.apiSoapDetail?.slug
+            )
+          ),
+          cards: compact(
+            attributes.apiData.data.map((item) =>
+              makeApiDataListPageCard(locale, item, slug)
+            )
+          ),
+          bannerLinks: attributes.bannerLinks.map(makeBannerLinkProps),
+          seo: attributes.seo,
+          updatedAt: attributes.updatedAt,
+          enableFilters: attributes.enableFilters,
+          tags: product.tags,
+        };
+      } catch (error) {
+        // eslint-disable-next-line functional/no-expression-statements
+        console.error(
+          `Error while processing API Data List Page with title "${attributes.title}":`,
+          error,
+          'Skipping...'
+        );
+        return null;
+      }
+    })
+  );


Same as the other section.
I will not follow the copilot suggestion here, but this comment raises some questions about the existing tests.

There are some already existing tests that are related to the make function apps/nextjs-website/src/lib/strapi/tests/makeApiDataListPages.test.ts . I will move this test inside the apiDataList folder alongside other files and refactor that test to use the new mapper function.

MarcoPonchia

I will remove unused files now deprecated from new fetcher and mapper stack like:

apps/nextjs-website/src/lib/strapi/fetches/fetchApiDataList.ts
apps/nextjs-website/src/lib/strapi/fetches/fetchApiDataListPages.ts
apps/nextjs-website/src/lib/strapi/makeProps/makeApiDataList.ts
apps/nextjs-website/src/lib/strapi/makeProps/makeApiDataListPages.ts

MarcoPonchia · 2026-03-03T11:16:46Z

apps/nextjs-website/src/lib/apiDataList/__tests__/mapper.test.ts

i will rename this file in mapper.test.ts

MarcoPonchia · 2026-03-03T11:17:10Z

apps/nextjs-website/src/lib/apiDataListPages/__tests__/mapper.test.ts

Also here i will rename this file in mapper.test.ts

…-for-strapi-5

…-5' into DEV-3677 # Conflicts: # apps/nextjs-website/src/components/templates/ApiDataListTemplate/ApiDataListTemplate.tsx

github-actions · 2026-03-04T14:45:33Z

Branch is not up to date with base branch

@tommaso1 it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

…' into DEV-3677

github-actions · 2026-03-16T17:06:42Z

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-3677

github-actions · 2026-03-16T17:06:43Z

This PR exceeds the recommended size of 800 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Sebastiano-Bertolin · 2026-03-18T13:47:49Z

Replaced by [DEV-3677 Refactor API data model and standardise property names](#2170)

Refactor api layer for api data model

f4e64b0

tommaso1 requested review from MarBert, MarcoPonchia and marcobottaro as code owners February 24, 2026 16:19

github-actions bot added the website label Feb 24, 2026

changeset

cbb6a72

github-actions bot assigned tommaso1 Feb 24, 2026

github-actions bot added the changeset label Feb 24, 2026

tommaso1 temporarily deployed to uat February 24, 2026 16:22 — with GitHub Actions Inactive

tommaso1 temporarily deployed to dev February 24, 2026 16:22 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod February 24, 2026 16:22 — with GitHub Actions Inactive

Merge branch 'main' into DEV-3677

0fa9fa5

tommaso1 temporarily deployed to uat February 24, 2026 19:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to dev February 24, 2026 19:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod February 24, 2026 19:47 — with GitHub Actions Inactive

Sebastiano-Bertolin requested a review from Copilot February 25, 2026 09:25

Copilot started reviewing on behalf of Sebastiano-Bertolin February 25, 2026 09:25 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

types

435be93

github-actions bot added the size/small label Feb 26, 2026

tommaso1 temporarily deployed to dev February 26, 2026 11:53 — with GitHub Actions Inactive

tommaso1 temporarily deployed to uat February 26, 2026 11:53 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod February 26, 2026 11:53 — with GitHub Actions Inactive

MarcoPonchia requested changes Mar 2, 2026

View reviewed changes

pr comments

ac70817

tommaso1 temporarily deployed to dev March 2, 2026 20:35 — with GitHub Actions Inactive

tommaso1 temporarily deployed to uat March 2, 2026 20:35 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod March 2, 2026 20:35 — with GitHub Actions Inactive

MarcoPonchia requested changes Mar 3, 2026

View reviewed changes

pr comments

2b1f6cd

tommaso1 temporarily deployed to uat March 3, 2026 11:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod March 3, 2026 11:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to dev March 3, 2026 11:47 — with GitHub Actions Inactive

github-user-name added 4 commits March 3, 2026 21:09

Merge remote-tracking branch 'origin/main' into DEV-3238-update-makes…

1b2e168

…-for-strapi-5

fix

c5677a6

lint

f5b5b8c

Merge remote-tracking branch 'origin/DEV-3238-update-makes-for-strapi…

9ea5105

…-5' into DEV-3677 # Conflicts: # apps/nextjs-website/src/components/templates/ApiDataListTemplate/ApiDataListTemplate.tsx

github-actions bot added the packages label Mar 4, 2026

tommaso1 changed the base branch from main to DEV-3238-update-makes-for-strapi-5 March 4, 2026 14:46

tommaso1 temporarily deployed to dev March 4, 2026 14:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to prod March 4, 2026 14:47 — with GitHub Actions Inactive

tommaso1 temporarily deployed to uat March 4, 2026 14:47 — with GitHub Actions Inactive

Sebastiano-Bertolin changed the base branch from DEV-3238-update-makes-for-strapi-5 to DEV-3238-strapi-5-feature-branch March 13, 2026 15:41

Merge remote-tracking branch 'origin/DEV-3238-strapi-5-feature-branch…

c038fe4

…' into DEV-3677

github-actions bot added the size/large label Mar 16, 2026

github-actions bot removed the size/small label Mar 16, 2026

Sebastiano-Bertolin temporarily deployed to dev March 16, 2026 17:08 — with GitHub Actions Inactive

Sebastiano-Bertolin temporarily deployed to prod March 16, 2026 17:08 — with GitHub Actions Inactive

Sebastiano-Bertolin temporarily deployed to uat March 16, 2026 17:08 — with GitHub Actions Inactive

Sebastiano-Bertolin self-assigned this Mar 17, 2026

Sebastiano-Bertolin marked this pull request as draft March 17, 2026 09:13

Sebastiano-Bertolin closed this Mar 18, 2026

Conversation

tommaso1 commented Feb 24, 2026

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

changeset-bot bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sebastiano-Bertolin commented Feb 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarcoPonchia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 4, 2026

Branch is not up to date with base branch

Uh oh!

github-actions bot commented Mar 16, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira Pull Request Link

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Sebastiano-Bertolin commented Mar 18, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

changeset-bot bot commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited by atlassian bot

Loading

Sebastiano-Bertolin commented Mar 18, 2026 •

edited by atlassian bot

Loading