[DEV-3880] Refactor tags and urlReplaceRepository API Layer#2197
Open
Sebastiano-Bertolin wants to merge 2 commits intoDEV-3859-refactor-webinars-and-webinarCategories-api-layerfrom
Conversation
🦋 Changeset detectedLatest commit: d53086f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-3880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of Changes
Tags handling refactor:
TagsRepositoryinapps/nextjs-website/src/lib/tags/index.tsto centralize fetching and mapping of tags, replacing previous scattered logic. ([1])strapi/types/tagandstrapi/fetches/fetchTags.tstotags/typesandtags/fetcher.ts, updating all import paths accordingly. ([1], [2], [3], [4])mapTagsProps,mapTagProps) and corresponding unit tests to ensure correct transformation from Strapi data to internal types. ([1], [2])strapi/makeProps/makeTags.ts. ([1])URL replacement map refactor:
UrlReplaceMapRepositoryand agetUrlReplaceMapAPI function, replacing the previousgetUrlReplaceMapPropsand related logic incmsApi.ts. ([1], [2])getUrlReplaceMapPropsto use the newgetUrlReplaceMapfunction, and changed imports to point to the new repository. ([1], [2], [3], [4], [5], [6], [7], [8], [9], [10], [11], [12])Cleanup and supporting changes:
cmsApi.tsrelating to tags and URL replacement map property mapping. ([1], [2])Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: