Skip to content

Conversation

@Krusty93
Copy link
Contributor

@Krusty93 Krusty93 commented Nov 20, 2025

This PR adds a mermaid diagram representing the architecture of Storage Account Terraform module.

NOTE: icons are not rendered on GitHub, neither the Terraform Registry. Currently working for a solution

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: ee70510

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
azure_storage_account Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Krusty93 Krusty93 marked this pull request as ready for review November 20, 2025 10:53
@Krusty93 Krusty93 requested a review from a team as a code owner November 20, 2025 10:54
The following diagram illustrates the architecture and relationships between the main components of this module:

```mermaid
flowchart LR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like icons are missing in the rendered markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, GitHub can't find them but locally they work. However, Terraform Registry can't load mermaid charts at all, so probably the only option is to (manually, yet) export the PNG file and referencing it from the README.md, and keeping the mermaid chart in a .mmd file.

cc @mamu0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm already looking into this. It seems the GitHub editor has a limitation about icons

@Krusty93 Krusty93 changed the title Ddd storage account module diagram in README.md Add storage account module diagram in README.md Nov 20, 2025
@Krusty93 Krusty93 marked this pull request as draft November 20, 2025 11:11
@github-actions
Copy link
Contributor

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..................................(no files to check)Skipped
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.07s

No .terraform.lock.hcl files to process.

Terraform fmt....................................................(no files to check)Skipped
terraform_docs on modules............................................................Passed
terraform_docs on resources......................................(no files to check)Skipped
Terraform validate with tflint...................................(no files to check)Skipped
Terraform validate...............................................(no files to check)Skipped
Terraform validate with trivy....................................(no files to check)Skipped

Generated on Mon Nov 24 11:32:49 UTC 2025
Run all checks on modified files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants